completed task 'stars' #3475
Closed
completed task 'stars' #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TKuts
commented
Aug 14, 2023
TKuts
commented
- DEMO LINK
- TEST REPORT LINK
lerastarynets
suggested changes
Aug 15, 2023
| .stars--2 :nth-child(n + 3), | ||
| .stars--3 :nth-child(n + 4), | ||
| .stars--4 :nth-child(n + 5) { | ||
| background-image: url("./images/star.svg"); |
There was a problem hiding this comment.
why not moving this style under stars_star selector?
src/style.css
Outdated
Comment on lines
9
to
11
| .stars :last-child { | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
you can use your margin-left: 4px; with :not(:first-child) instead of the above
VitaliyBodnar
suggested changes
Aug 15, 2023
src/style.css
Outdated
Comment on lines
28
to
34
| .stars--1 :first-child, | ||
| .stars--2 :nth-child(-n + 2), | ||
| .stars--3 :nth-child(-n + 3), | ||
| .stars--4 :nth-child(-n + 4), | ||
| .stars--5 :nth-child(-n + 5) { | ||
| background-image: url("./images/star-active.svg"); | ||
| } |
There was a problem hiding this comment.
don't see any sense in adding a no-active background modificator, you can add a no-active start for every starts
after that add modificator only for the active start
for instance:
mykhalenych
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.